Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fetching and deleting EKS Access Entries #7422

Merged
merged 18 commits into from
Dec 20, 2023
Merged

Add support for fetching and deleting EKS Access Entries #7422

merged 18 commits into from
Dec 20, 2023

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Dec 19, 2023 •
edited

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the kind/feature New feature or request label Dec 19, 2023
@TiberiuGC TiberiuGC force-pushed the access-entries-get-delete branch 2 times, most recently from efc0945 to f9d783e Compare December 19, 2023 11:20
@TiberiuGC TiberiuGC changed the title Add support for fetching and deleting EKS access entries Add support for fetching and deleting EKS Access Entries Dec 19, 2023
@cPu1 cPu1 changed the base branch from access-entries to main December 20, 2023 13:04
TiberiuGC and others added 18 commits December 20, 2023 15:11
@TiberiuGC
Add support for access entries get and delete commands
fa0e418
@TiberiuGC
Add new utils command to enable access entries API
e9a7906
@TiberiuGC
Remove node policy check
ab37c46
@TiberiuGC
refactor get and delete command to check API availability using clust…
9f65f44 
…er status
@TiberiuGC
update access entries integration test to account for multiple use cases
1cab924
@TiberiuGC
delete access entries stacks on cluster deletion + refactor integrati…
a2ed32b 
…on test
@TiberiuGC
fix unit + integration tests
780f268
@TiberiuGC
patch validations
0b32628
@TiberiuGC
Fix error message
db64cfa
@TiberiuGC
parse principalARN as cobra value instead of string
b608346
@TiberiuGC
change package aliasing
63013de
@TiberiuGC
only pass necessary fields to access entry action structs
9ff00ee
@TiberiuGC
Fix lint errors
82f7341
@TiberiuGC
Fix dry-run test
b80d890
@TiberiuGC
add test case for disabled cluster admin permissions
e7fd5d6
@TiberiuGC
address PR comments
70d5c61
@TiberiuGC
fix static errors
1da896e
@TiberiuGC
remove user creation from integration test
c2907cd
@cPu1 cPu1 merged commit c284cc5 into main Dec 20, 2023
9 checks passed
@cPu1 cPu1 deleted the access-entries-get-delete branch December 20, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TiberiuGC @cPu1