Skip draining managed nodegroups when deleting cluster #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiang-zhang
added
area/managed-nodegroup
yuxiang-zhang
changed the title
a-hilaly
approved these changes
Jan 30, 2024
yuxiang-zhang
force-pushed
the
drain-unmanaged-ng-only
branch
from
1d9cd7d
to
aec56df
Compare
yuxiang-zhang
commented
Jan 31, 2024
| logger.Info("will drain %d unmanaged nodegroup(s) in cluster %q", len(cfg.NodeGroups), cfg.Metadata.Name) | ||
|
|
||
| drainInput := &nodegroup.DrainInput{ | ||
| NodeGroups: cmdutils.ToKubeNodeGroups(cfg), | ||
| NodeGroups: cmdutils.ToKubeNodeGroups(cfg.NodeGroups, []*api.ManagedNodeGroup{}), |
There was a problem hiding this comment.
Changed the function signature for allowing specifying empty list of either unmanaged/managed nodegroups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As pointed out in #4205, the code intended to only drain unmanaged nodegroups since EKS should take care of managed nodegroups. However,
cmdutils.ToKubeNodeGroupsfunction has been populating theDrainInputwith both unmanaged and managed nodegroups. This causes an inconsistency where when usingeksctl delete cluster --config-filewith a config that specify the managed nodegroup config, that managed nodegroup get drained; buteksctl delete cluster --namedeleting the same cluster will skip draining the same managed nodegroup, because https://github.com/yuxiang-zhang/eksctl/blob/1d9cd7dc8370716d711e45bf17e2967434eb88f4/pkg/actions/cluster/delete.go#L174-L179 only populates the unmanaged nodegroups.Regardless of using
--config-file, the behaviour for deleting a cluster should be consistent: either drain managed nodegroups, or skip draining managed nodegroups. This change sticks with the original intent from #4205, that is to skip draining managed nodegroups.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く