Add support for Access Entry type #7522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiang-zhang
force-pushed
the
add-access-entry-type
branch
2 times, most recently
from
e7fd636
to
09d4165
Compare
a-hilaly
reviewed
Feb 2, 2024
| @@ -6,7 +6,7 @@ kind: ClusterConfig | |||
| metadata: | |||
| name: access-entries-cluster | |||
| region: us-west-2 | |||
| version: '1.25' | |||
There was a problem hiding this comment.
Did this example work before? or it's not being tested at all?
There was a problem hiding this comment.
Yeah it worked with non STANDARD types. I just updated to show the new fields in use
| PrincipalARN ARN `json:"principalARN"` | ||
| // +optional |
There was a problem hiding this comment.
Not very sure here but i think // +optional are supposed to be a one line comment. They are parsed by controller-gen if i'm not mistaken..
There was a problem hiding this comment.
There was a problem hiding this comment.
Do we use controller-gen to generate CRDs for eksctl?
a-hilaly
previously approved these changes
Feb 2, 2024
yuxiang-zhang
force-pushed
the
add-access-entry-type
branch
from
09d4165
to
a222077
Compare
yuxiang-zhang
force-pushed
the
add-access-entry-type
branch
from
a222077
to
47c1309
Compare
a-hilaly
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7446
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く