Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict parser is case-insensitive #753

Closed
errordeveloper opened this issue Apr 25, 2019 · 6 comments
Closed

strict parser is case-insensitive #753

errordeveloper opened this issue Apr 25, 2019 · 6 comments
Labels
area/config-file kind/bug priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@errordeveloper
Copy link
Contributor

We have enabled strict parsing to detect unknown keys, e.g.:

[✖]  loading config file "test.yaml": error unmarshaling JSON: while decoding JSON: json: unknown field "subnetz"

or:

[✖]  loading config file "test.yaml": error unmarshaling JSON: while decoding JSON: json: unknown field "nodeGroup"

But it appears that strict parser doesn't detect keys that had been misspelled by mix-case.

For example: Subnets are sUbnetS, or NodeGroups and nodegroups, don't result in parser error.

This looks like a bug in the parser, we should look into what causes it, and of course file a generic issue. We use sigs.k8s.io/yaml for this.

@martina-if
Copy link
Contributor

I'm not sure if we want to use it I tried it and gopkg.in/yaml.v2 is case sensitive.

@martina-if
Copy link
Contributor

I submited an issue kubernetes-sigs/yaml#15

@errordeveloper
Copy link
Contributor Author

Interesting. Could you share a test case with gopkg.in/yaml.v2? there is also gopkg.in/yaml.v3, which we should try (see kubernetes-sigs/yaml#17 & kubernetes-sigs/yaml#18).

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Jun 21, 2019

kubernetes-sigs/yaml#19 is a potential fix, it actually seems to move along... maybe a good idea to try the patch?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jan 27, 2021
@michaelbeaumont michaelbeaumont mentioned this issue Feb 10, 2021
7 tasks
@michaelbeaumont michaelbeaumont added priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases and removed priority/backlog Not staffed at the moment. Help wanted. labels Feb 10, 2021
@cPu1 cPu1 changed the title strict parser is case-insentive strict parser is case-insensitive Mar 3, 2021
@nikimanoledaki
Copy link
Contributor

This issue has been open for a while, closing due to staleness but happy to reopen if the issue persists.

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
…pshot

Resize filesystem when restore a snapshot to larger size volume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config-file kind/bug priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Development

No branches or pull requests

7 participants