Bump dependencies #7554
Merged
Bump dependencies #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiang-zhang
added
dependencies
yuxiang-zhang
force-pushed
the
bump-deps
branch
from
52557ab
to
233ec1c
Compare
a-hilaly
reviewed
Feb 15, 2024
pkg/kubernetes/client.go
Outdated
Comment on lines
543
to
547
| expander := restmapper.NewShortcutExpander(mapper, discoveryClient, nil) | ||
| return expander, nil | ||
| } |
There was a problem hiding this comment.
I'm not super sure if this is correct to do (passing a nil function)
There was a problem hiding this comment.
Looks like it's safe.. https://github.com/kubernetes/client-go/blob/master/restmapper/shortcut.go#L167-L169
There was a problem hiding this comment.
Maybe we can pass a function that will log the warning?
yuxiang-zhang
commented
Feb 15, 2024
pkg/kubernetes/client.go
Outdated
| @@ -540,7 +540,7 @@ func (c *SimpleRESTClientGetter) ToRESTMapper() (meta.RESTMapper, error) { | |||
| } | |||
|
|
|||
| mapper := restmapper.NewDeferredDiscoveryRESTMapper(discoveryClient) | |||
| expander := restmapper.NewShortcutExpander(mapper, discoveryClient) | |||
| expander := restmapper.NewShortcutExpander(mapper, discoveryClient, nil) | |||
There was a problem hiding this comment.
Suggested change
| expander := restmapper.NewShortcutExpander(mapper, discoveryClient, nil) | |
| expander := restmapper.NewShortcutExpander(mapper, discoveryClient, func(a string) { | |
| logger.Warning("unexpected warning message %s", a) | |
| }) |
There was a problem hiding this comment.
how about this? @a-hilaly
yuxiang-zhang
force-pushed
the
bump-deps
branch
from
233ec1c
to
6e9d017
Compare
Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
Update go version to 1.21 in actions
yuxiang-zhang
force-pushed
the
bump-deps
branch
from
6e9d017
to
0cb2f05
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #7472 #7492 #7494 #7506 #7508 #7510 #7514 #7527 #7528 #7529 #7531 #7532 #7533 #7534 #7535 #7536 #7537 #7544 #7545 #7546 #7547
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く