Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update docs about queue name change #6062

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

maxforasteiro
Copy link
Contributor

@maxforasteiro maxforasteiro commented Apr 19, 2024

(it doesn't) Fix eksctl-io/eksctl#7697 (but here's an issue caused by this)

Description

Seems to have been added in #4840
I'm just adding the docs because we spent one month having to deal with spot nodes being shutdown in 50s

How was this change tested?

no test needed

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maxforasteiro maxforasteiro requested a review from a team as a code owner April 19, 2024 09:19
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3de6bae
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66260e7bce8d890008f6d0b3

@maxforasteiro
Copy link
Contributor Author

tagging @jonathan-innis as the author of the original PR 😄

@jonathan-innis jonathan-innis self-assigned this Apr 21, 2024
@coveralls
Copy link

coveralls commented Apr 21, 2024

Pull Request Test Coverage Report for Build 8780023332

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 81.994%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8769944868: 0.02%
Covered Lines: 5396
Relevant Lines: 6581

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) April 23, 2024 07:14
@jonathan-innis jonathan-innis merged commit fe6c639 into aws:main Apr 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Karpenter setting interruptionQueueName renamed to interruptionQueue
3 participants