orgid attribute from SAML response not used on user creation

[bloo-dye]

Detailed description of the problem

Was looking into the fallback from email to internal ID with saml, but it seems the internal ID is never synchronized in the first place.

Expected Behavior

In the docs it is mentioned that orgid is going to be set for user creation on the fly.

Steps to reproduce the behavior

Register user with SAML. Internal ID remains "unset"

What eLabFTW version are you using? Visible in bottom right of a page.

5.0.4

Do you have any idea what may have caused this?

I checked the saml.php and it seems the parameter orgid is not used on user creation. The orgid can be added to the function "getUser" (as well as "fromExternal"/"fromScratch" down the line). This works as long a the team is not interactively selected by the user.
In the public function "createOne" the optional parameter orgid is already present.

Do you have an idea how to solve the issue?

Not sure how to deal with when team is selected by user.

Additional information

No response

[NicolasCARPi]

I guess the orgid information must be carried over with the name/email during team selection.

[NicolasCARPi]

Fixed in #5048