Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "enable_metrics" or "include_metrics" option #3234

Open
fbaligand opened this issue Jul 11, 2023 · 2 comments
Open

Add a "enable_metrics" or "include_metrics" option #3234

fbaligand opened this issue Jul 11, 2023 · 2 comments
Labels
agent-java community Issues and PRs created by the community enhancement Enhancement of an existing feature

Comments

@fbaligand
Copy link

Is your feature request related to a problem?

Currently, I'm able to define which metrics are disabled, but on the contrary, I can't define which metrics are enabled/included. So with a library like micrometers, lots of metrics are by default included, that is too much.

Describe the solution you'd like

I would like a new option that allows to define which metrics are enabled/disabled. It could be called "enable_metrics" or "include_metrics", and it would be complementary with "disable_metrics". First "enable_metrics" define a first list of collected metrics, then "disable_metrics" remove some metrics from this list.

Describe alternatives you've considered

I don't see an alternative

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Jul 11, 2023
@jackshirazi jackshirazi added enhancement Enhancement of an existing feature and removed triage labels Jul 17, 2023
@jackshirazi
Copy link
Contributor

Hi, thank you for the suggestion, it seems quite reasonable. However we don't have the resources to priortize this enhancement any time soon. We'd be delighted for a contribution that enables this!

If you (or anyone) does look at contributing a PR that enables this, it's worth considering whether the enable_metrics would apply to all metrics or only custom (ie non-JVM metrics). Perhaps enable_custom_metrics might be a better name in that case

@fbaligand
Copy link
Author

Thanks for the answer.
This would be a nice enhancement to implement.
Maybe I will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community enhancement Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants