Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring metric set size #3354

Open
kelunik opened this issue Oct 10, 2023 · 3 comments
Open

Monitoring metric set size #3354

kelunik opened this issue Oct 10, 2023 · 3 comments
Labels
agent-java community Issues and PRs created by the community

Comments

@kelunik
Copy link
Contributor

kelunik commented Oct 10, 2023

Is your feature request related to a problem?

We're running into the default metric_set_limit (#2148, #2717) (probably due to many different transaction names). We can obviously increase the limit now based on a good guess, but it doesn't seem possible to examine the current metric set size.

We'd like to be able to monitor the metric set size to ensure we're well below the limit, but still keep the limit rather low to prevent explosion.

Describe the solution you'd like

It'd be great if we could add a micrometer gauge that monitors the metric set size, or if this becomes a built-in metric.

Describe alternatives you've considered

Raising the limit higher than necessary.

@kelunik kelunik changed the title Monitoring metric_set size Monitoring metric set size Oct 10, 2023
@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Oct 10, 2023
@jackshirazi
Copy link
Contributor

would periodically logging the value work for you?

@kelunik
Copy link
Contributor Author

kelunik commented Oct 15, 2023

Logging would be a good start, but my preferred way would be exposing the size either via the health metrics or via a public API, so I can create my own metric from that.

@jackshirazi
Copy link
Contributor

Adding a DEBUG log is easily done. Adding anything else is not going to be prioritized by the Elastic team as there are not a lot of people requesting this, it's quite niche. So I can add a DEBUG log, or I'm happy for you to create a PR with your proposed addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community
Projects
None yet
Development

No branches or pull requests

2 participants