Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish script #211

Closed
hmdhk opened this issue Mar 12, 2019 · 3 comments · Fixed by #287
Closed

Fix publish script #211

hmdhk opened this issue Mar 12, 2019 · 3 comments · Fixed by #287
Assignees
@vigneshshanmugam

Comments

@hmdhk
Copy link
Contributor

hmdhk commented Mar 12, 2019 •
edited by vigneshshanmugam

Bugs:

  • Fix the version check script
  • Need to add --access public to npm publish command (through lerna)
  • lerna should prompt for 2fa authentication OTP (currently it fails) before each package publish

Enhancements:

  • The publish scripts should pause before committing the changes for the release, so that we can edit changelog if necessary
  • We should check the required env variables before running the actual publish script (currently only GITHUB_TOKEN)
  • Check if there’s a user logged in for npm
  • run release-github in the same script (chore: add release-github to the release script #275)
@hmdhk
Copy link
Contributor Author

hmdhk commented Mar 14, 2019

@vigneshshanmugam any thoughts?

@vigneshshanmugam
Copy link
Member

Lerna issue on 2fa lerna/lerna#1091, There is a branch with the PR for the fix.

@hmdhk hmdhk added the blocked label Mar 21, 2019
@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented May 17, 2019 •
edited

Prompts for 2FA is fixed in lerna 3.14.0 - https://github.com/lerna/lerna/releases/tag/v3.14.0

@vigneshshanmugam vigneshshanmugam mentioned this issue May 23, 2019
Merged
@hmdhk hmdhk removed the blocked label Jun 4, 2019
@vigneshshanmugam vigneshshanmugam self-assigned this Jun 11, 2019
@vigneshshanmugam vigneshshanmugam mentioned this issue Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vigneshshanmugam vigneshshanmugam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rum): fix release script vigneshshanmugam/apm-agent-js-base
3 participants
@vigneshshanmugam @hmdhk @alvarolobato