deployment.Reconcile and daemonset.Reconcile lead to unnecessary updates

[pebrc]

We include the full resource into the hash calculation including the ResourceVersion that leads to an unnecessary update cycle where we re-hash and update the resource again after an update due to the resource version changing.

cloud-on-k8s/pkg/controller/common/daemonset/reconcile.go

Lines 68 to 71 in 2c6b487

	func WithTemplateHash(d appsv1.DaemonSet) appsv1.DaemonSet {
	dCopy := *d.DeepCopy()
	dCopy.Labels = hash.SetTemplateHashLabel(dCopy.Labels, dCopy)
	return dCopy

cloud-on-k8s/pkg/controller/common/deployment/reconcile.go

Lines 82 to 85 in d91f289

	func WithTemplateHash(d appsv1.Deployment) appsv1.Deployment {
	dCopy := *d.DeepCopy()
	dCopy.Labels = hash.SetTemplateHashLabel(dCopy.Labels, dCopy)
	return dCopy

This behaviour is actually hidden in our unit tests, because FakeClient ignores ResourceVersion and does not fully simulate a real client (until controller-runtime 0.6.1 at least)

[pebrc]

This is a non-issue. I misinterpreted the effects of this bug kubernetes-sigs/controller-runtime#926