Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic for filtering of unhealthy allocators to target more than only disconnected allocators #410

Open
zenitraM opened this issue Sep 20, 2022 · 0 comments

Comments

@zenitraM
Copy link
Member

In recent ECE releases, we expose new attributes that allow us to determine the overall health of allocators based on more attributes than just the connectivity, including data around several other health checks reported by the allocator itself.

However, the API exposes a hardcoded constant for searching for unhealthy allocators that does not use those attributes and rather depends on just its connectivity, which causes that it will not display allocators failing in some specific failure modes other than lack of connectivity:

UnhealthyQuery = "status.connected:false AND _exists_:instances"

This attribute is used by ecctl:
https://github.com/elastic/ecctl/blob/056f4d673adc428362a987b697e589579580c3ee/cmd/platform/allocator/list.go#L63
and other SDK-powered applications when filtering for unhealthy allocators. We would want to update this query to allow to also target allocators that are connected but not healthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant