Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring capabilities to the pool #95

Open
ppapapetrou76 opened this issue Apr 16, 2020 · 0 comments
Open

Add monitoring capabilities to the pool #95

ppapapetrou76 opened this issue Apr 16, 2020 · 0 comments

Comments

@ppapapetrou76
Copy link
Contributor

ppapapetrou76 commented Apr 16, 2020

Overview

Our awesome pool is heavily used in cloud-deployer and it's super fast!
We would like to send dynamic slack notifications during the workers' processing like how many items have been processed so far, how many pending, errors etc.

Possible Implementation

I'd consider two different implementations

Add API so that consumers call it to get the information needed

This gives consumers the flexibility of poking the API directly and processing the results as required. Ideally, I'd expect that results are the structure that has been passed in workers during pool initialization

Inject a function inside the pool

This would require the addition of 2-3 new fields during pool creation

  • Function to inject
  • Frequency
  • Initial timeout before injecting the function for the first time

The pool would know then when to run this function internally
This gives less flexibility to the consumers but hides all the details inside the pool

Context

Make our awesome pool more awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant