Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Refactor Rule Formatter #3558

Open
6 tasks
Mikaayenson opened this issue Apr 2, 2024 · 1 comment
Open
6 tasks

[Meta] Refactor Rule Formatter #3558

Mikaayenson opened this issue Apr 2, 2024 · 1 comment
Labels
Area: DED enhancement New feature or request Meta python Internal python for the repository Team: TRADE

Comments

@Mikaayenson
Copy link
Collaborator

Parent Epic (If Applicable)

https://github.com/elastic/security-team/issues/8718

Meta Summary

The formatter was once written when the schemas were flat structures. Now that they have evolved to nested structures, the rule formatter should be refactored.

  • The new solution should easily be able to specify the order of the toml file.
  • The solution should remain consistent and not unintentionally create new sha256 calculations.
  • The solution should still support some of the old features:
    • text wrapping after a certain character limit
    • skipping fields that should not be formatted or normalized

Estimated Time to Complete

Potential Blockers

Tasklist

Meta Tasks

Resources / References

@Mikaayenson Mikaayenson added enhancement New feature or request python Internal python for the repository Area: DED Team: TRADE Meta labels Apr 2, 2024
@shashank-elastic
Copy link
Contributor

Edge case of formatter failing on nested fields as illustrated in #3681 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: DED enhancement New feature or request Meta python Internal python for the repository Team: TRADE
Projects
None yet
Development

No branches or pull requests

2 participants