You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when specifying a custom directory some of the unit tests in DAC fail. Specifically these are locked versions related checks. Since the branches specified in the stack-schema-map are expected to be different in a custom config, we will need a way to handle cases where customers wish to run unit tests with these custom configs.
I see two different approaches that we could take to address this problem, or we could use a combination of both.
We could use the unit tests configs to have users bypass these checks by default unless they would like to have them.
We could use the bypass_version_lock config value when merged to also apply for these test cases
Example: tests/test_gh_workflows.py which tests that the default versions in the lock-versions workflow mirror those from the schema-map.
The text was updated successfully, but these errors were encountered:
I'm not sure if we need a unit test for this. If a user is using custom rules, wouldn't these test cases be just something they bypass in their config?
Summary
Currently when specifying a custom directory some of the unit tests in DAC fail. Specifically these are locked versions related checks. Since the branches specified in the stack-schema-map are expected to be different in a custom config, we will need a way to handle cases where customers wish to run unit tests with these custom configs.
I see two different approaches that we could take to address this problem, or we could use a combination of both.
bypass_version_lock
config value when merged to also apply for these test casesExample:
tests/test_gh_workflows.py
which tests that the default versions in the lock-versions workflow mirror those from the schema-map.The text was updated successfully, but these errors were encountered: