Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR][DAC] Unit Test Locked Version Support for Custom Config #3682

Closed
eric-forte-elastic opened this issue May 15, 2024 · 2 comments · Fixed by #3684
Closed

[FR][DAC] Unit Test Locked Version Support for Custom Config #3682

eric-forte-elastic opened this issue May 15, 2024 · 2 comments · Fixed by #3684
Assignees
Labels

Comments

@eric-forte-elastic
Copy link
Collaborator

Summary

Currently when specifying a custom directory some of the unit tests in DAC fail. Specifically these are locked versions related checks. Since the branches specified in the stack-schema-map are expected to be different in a custom config, we will need a way to handle cases where customers wish to run unit tests with these custom configs.

I see two different approaches that we could take to address this problem, or we could use a combination of both.

  1. We could use the unit tests configs to have users bypass these checks by default unless they would like to have them.
  2. We could use the bypass_version_lock config value when merged to also apply for these test cases

Example:
tests/test_gh_workflows.py which tests that the default versions in the lock-versions workflow mirror those from the schema-map.
lock_version_test

@Mikaayenson
Copy link
Collaborator

I'm not sure if we need a unit test for this. If a user is using custom rules, wouldn't these test cases be just something they bypass in their config?

@eric-forte-elastic
Copy link
Collaborator Author

Good discussion, going to add a flag in the setup-config to be a helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants