Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update loggers to use the bool retval of formatError, formatHttpRequest, and formatHttpResponse #70

Open
trentm opened this issue Mar 18, 2021 · 0 comments
Open

update loggers to use the bool retval of formatError, formatHttpRequest, and formatHttpResponse #70

trentm opened this issue Mar 18, 2021 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Mar 18, 2021

Now that formatError, formatHttpRequest, and formatHttpResponse return a bool for whether they processed the field, the loggers should use that to pass through unprocessed fields on the log record. Currently logging a req field that isn't an HTTP request will (a) blow up in v1.0.0, (b) silently drop the "req" field in v1.1.0. I think a future version should log that req field unchanged.
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trentm