Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heatmap legend with linear color scale contains duplicate 0 #1166

Closed
darnautov opened this issue May 26, 2021 · 1 comment · Fixed by #1273
Closed

Heatmap legend with linear color scale contains duplicate 0 #1166

darnautov opened this issue May 26, 2021 · 1 comment · Fixed by #1273
Assignees
@markov00
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:High :legend Legend related issue released Issue released publicly
Projects
Heatmap Beta

Comments

@darnautov
Copy link
Contributor

darnautov commented May 26, 2021 •
edited by nickofthyme

Describe the bug
Heatmap chart with colorScale={ScaleType.Linear} ends up with duplicate 0 in legend items.

To Reproduce
Provide a dataset with values range from 0 to N.

See https://codesandbox.io/s/damp-https-2rspz?file=/src/App.tsx

Expected behaviour
Legend doesn't contain duplicate items.

Screenshots
image

Kibana Cross Issues
elastic/kibana#97978
@darnautov darnautov added bug Something isn't working :legend Legend related issue :heatmap Heatmap/Swimlane chart related issue labels May 26, 2021
@darnautov darnautov mentioned this issue May 27, 2021
Merged
7 tasks
@flash1293 flash1293 mentioned this issue Jun 14, 2021
Closed
@markov00 markov00 added this to To do in Heatmap Beta Jun 22, 2021
@markov00 markov00 self-assigned this Jul 27, 2021
@markov00 markov00 moved this from To do to In progress in Heatmap Beta Jul 28, 2021
@markov00 markov00 mentioned this issue Jul 28, 2021
Merged
5 tasks
Heatmap Beta automation moved this from In progress to Done Aug 16, 2021
markov00 added a commit that referenced this issue Aug 16, 2021
@markov00
fix(heatmap): compute nice legend items from color scale (#1273)
0d392ae 
The heatmap legend now correctly shows all the colors and values associated with the chosen scale, without duplicates and with all the available color bands computed.

fix #1166, fix #1191, fix #1192
nickofthyme pushed a commit that referenced this issue Aug 16, 2021
@semantic-release-bot
chore(release): 33.2.3 [skip ci]
640b737 
## [33.2.3](v33.2.2...v33.2.3) (2021-08-16)

### Bug Fixes

* **heatmap:** compute nice legend items from color scale  ([#1273](#1273)) ([0d392ae](0d392ae)), closes [#1166](#1166) [#1191](#1191) [#1192](#1192)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 33.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:High :legend Legend related issue released Issue released publicly
Projects
No open projects
Heatmap Beta
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(heatmap): compute nice legend items from color scale markov00/elastic-charts
3 participants
@markov00 @darnautov @nickofthyme