Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The brushTool renders outside the projection area #1216

Closed
markov00 opened this issue Jun 22, 2021 · 1 comment · Fixed by #1270
Closed

The brushTool renders outside the projection area #1216

markov00 opened this issue Jun 22, 2021 · 1 comment · Fixed by #1270
Assignees
@rshen91
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:Medium :interactions Interactions related issue released Issue released publicly
Projects
Heatmap Beta

Comments

@markov00
Copy link
Member

Describe the bug
The brushTool is not constrained within the heatmap projection area

To Reproduce
Steps to reproduce the behavior:

  1. Enable the brushTool visibility in the config:
brushTool: {
  visible: true,
}
  1. Try to brush outside the projection area
  2. The brushTool rectangle is rendered outside that area.

Expected behaviour
The brushTool should be constrained inside the projection area.

Screenshots

Jun-22-2021 20-00-25

Version (please complete the following information):

  • Elastic Charts: 30.x

Additional context
n/a

Errors in browser console
n/a
@markov00 markov00 added bug Something isn't working :interactions Interactions related issue :heatmap Heatmap/Swimlane chart related issue labels Jun 22, 2021
@markov00 markov00 mentioned this issue Jun 22, 2021
Merged
12 tasks
@markov00 markov00 added this to To do in Heatmap Beta Jun 22, 2021
@rshen91 rshen91 self-assigned this Jul 22, 2021
@rshen91 rshen91 mentioned this issue Jul 27, 2021
Merged
3 tasks
@markov00 markov00 moved this from To do to In progress in Heatmap Beta Jul 28, 2021
Heatmap Beta automation moved this from In progress to Done Aug 20, 2021
rshen91 added a commit that referenced this issue Aug 20, 2021
@rshen91
fix(heatmap): limit brush tool (#1270)
509cf42 
Closes #1216
nickofthyme pushed a commit that referenced this issue Aug 23, 2021
@semantic-release-bot
chore(release): 34.2.0 [skip ci]
a7c19ce 
# [34.2.0](v34.1.1...v34.2.0) (2021-08-23)

### Bug Fixes

* **heatmap:** limit brush tool ([#1270](#1270)) ([509cf42](509cf42)), closes [#1216](#1216)

### Features

* **goal:** dark mode with theme controls ([#1299](#1299)) ([3a583e5](3a583e5))
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 34.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:Medium :interactions Interactions related issue released Issue released publicly
Projects
No open projects
Heatmap Beta
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(heatmap): limit brush tool rshen91/elastic-charts
3 participants
@markov00 @nickofthyme @rshen91