Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): goal chart bugs #1256

Merged
merged 8 commits into from Jul 16, 2021
Merged

fix(a11y): goal chart bugs #1256

merged 8 commits into from Jul 16, 2021

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Jul 15, 2021 •
edited

Summary

This PR addresses some bugs with #1161.

Details

  • Fixes the minValue is the current value in the goal semantic description
  • Fixes key react red error
  • Fixes the typo $ under Target for Types.tsx
  • Adds mergePartial(defaultConfig, partialConfig, { mergeOptionalPartialValues: true }); where relevant for RecursivePartial configs (goal charts, heatmap charts, partition charts, word cloud charts)
  • I deleted the existing vrts and re-ran them (to account for the number of changed files)

@rshen91 rshen91 added bug Something isn't working :accessibility Accessibility related issue labels Jul 15, 2021
@rshen91 rshen91 requested a review from myasonik July 15, 2021 17:32
@rshen91 rshen91 marked this pull request as ready for review July 15, 2021 21:08
@rshen91
Copy link
Contributor Author

rshen91 commented Jul 15, 2021

jenkins test this

myasonik
myasonik approved these changes Jul 16, 2021
View reviewed changes
Copy link

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

nickofthyme
nickofthyme approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rshen91
Copy link
Contributor Author

rshen91 commented Jul 16, 2021

jenkins test this

@rshen91 rshen91 merged commit 5ff47dd into elastic:master Jul 16, 2021
@rshen91 rshen91 deleted the fix-semantics branch July 16, 2021 15:17
nickofthyme pushed a commit that referenced this pull request Jul 16, 2021
@semantic-release-bot
chore(release): 33.0.1 [skip ci]
fb8f719 
## [33.0.1](v33.0.0...v33.0.1) (2021-07-16)

### Bug Fixes

* **a11y:** goal chart bugs ([#1256](#1256)) ([5ff47dd](5ff47dd))
* slackbot package name ([#1254](#1254)) ([7999020](7999020))
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 33.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
:accessibility Accessibility related issue bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rshen91 @nickofthyme @myasonik