Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persisted color via color picker #1265

Merged
merged 3 commits into from Jul 28, 2021
Merged

fix: persisted color via color picker #1265

merged 3 commits into from Jul 28, 2021

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Jul 21, 2021 •
edited

Summary

Fixes a regression that disabled persisted colors when using the legendColorPicker prop.

Details

This setting is more for internal use as all users of charts should persist the colors outside of memory but still a regession.

Issues

fixes #1264

Checklist

  • The proper chart type label was added (e.g. :xy, :partition) if the PR involves a specific chart type
  • The proper feature label was added (e.g. :interactions, :axis) if the PR involves a specific chart feature
  • Whenever possible, please check if the closing issue is connected to a running GH project
  • Any consumer-facing exports were added to packages/charts/src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@markov00 markov00 added :legend Legend related issue bug Something isn't working regression labels Jul 26, 2021
markov00
markov00 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works fine!

@nickofthyme nickofthyme enabled auto-merge (squash) July 28, 2021 15:00
@nickofthyme nickofthyme merged commit 4205a7f into elastic:master Jul 28, 2021
nickofthyme pushed a commit that referenced this pull request Jul 28, 2021
@semantic-release-bot
chore(release): 33.1.0 [skip ci]
051cabc 
# [33.1.0](v33.0.2...v33.1.0) (2021-07-28)

### Bug Fixes

* persisted color via color picker ([#1265](#1265)) ([4205a7f](4205a7f))

### Features

* **legend:** add point shape styles to legend item ([#1227](#1227)) ([46be1d1](46be1d1))
* **partition:** waffle chart ([#1255](#1255)) ([156662a](156662a))
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 33.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jul 28, 2021
@nickofthyme nickofthyme deleted the fix-persisted-color branch August 24, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working :legend Legend related issue regression released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

persisted color is broken
2 participants
@nickofthyme @markov00