Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: polarity value filtering on non-log scales #1292

Merged
merged 5 commits into from Aug 10, 2021
Merged

fix: polarity value filtering on non-log scales #1292

merged 5 commits into from Aug 10, 2021

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 9, 2021 •
edited

Summary

Fixes a bug that filtered out wrong values based on data polarity.

Details

There is logic to filter out values based on when the scale type is logarithmic to prevent 0 values and mixed polarity. This logic failed to correctly account for the scale type in all cases, causing points to not be rendered.

Screen Recording 2021-08-09 at 04 09 47 PM

Issues

fix #1290

Checklist

  • The proper chart type label was added (e.g. :xy, :partition) if the PR involves a specific chart type
  • The proper feature label was added (e.g. :interactions, :axis) if the PR involves a specific chart feature
  • Whenever possible, please check if the closing issue is connected to a running GH project
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added bug Something isn't working :data Data/series/scales related issue :xy Bar/Line/Area chart related labels Aug 9, 2021
rshen91
rshen91 reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!! LGTM tested locally

@nickofthyme nickofthyme merged commit e75ad0b into elastic:master Aug 10, 2021
@nickofthyme nickofthyme deleted the fix-zero-neg-values branch August 10, 2021 13:50
nickofthyme pushed a commit that referenced this pull request Aug 10, 2021
@semantic-release-bot
chore(release): 33.2.2 [skip ci]
e4618fd 
## [33.2.2](v33.2.1...v33.2.2) (2021-08-10)

### Bug Fixes

* polarity value filtering on non-log scales ([#1292](#1292)) ([e75ad0b](e75ad0b))
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 33.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshen91 rshen91 rshen91 approved these changes

@monfera monfera Awaiting requested review from monfera

Assignees
No one assigned
Labels
bug Something isn't working :data Data/series/scales related issue released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative values with zero values do not render
2 participants
@nickofthyme @rshen91