Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(goal): optional target tick #1301

Merged
merged 6 commits into from
Aug 17, 2021
Merged

feat(goal): optional target tick #1301

merged 6 commits into from
Aug 17, 2021

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 15, 2021 •
edited

Summary

Makes goal chart target tick line optional

Screen Recording 2021-08-14 at 11 14 36 PM

Issues

close #1239

Checklist

  • The proper chart type label was added (e.g. :xy, :partition) if the PR involves a specific chart type
  • The proper feature label was added (e.g. :interactions, :axis) if the PR involves a specific chart feature
  • Whenever possible, please check if the closing issue is connected to a running GH project
  • Any consumer-facing exports were added to packages/charts/src/index.ts (and stories only import from ../src except for test data & storybook)
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added enhancement New feature or request :data Data/series/scales related issue :goal/gauge (old) Old Goal/Gauge chart related issues labels Aug 15, 2021
@nickofthyme
Copy link
Collaborator Author

Jenkins test this please

markov00
markov00 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean and simple implementation

@nickofthyme nickofthyme enabled auto-merge (squash) August 16, 2021 14:32
@nickofthyme nickofthyme merged commit 88adf22 into elastic:master Aug 17, 2021
@nickofthyme nickofthyme deleted the disable-goal-target branch August 17, 2021 14:24
nickofthyme pushed a commit that referenced this pull request Aug 19, 2021
@semantic-release-bot
chore(release): 34.1.0 [skip ci]
107617a 
# [34.1.0](v34.0.0...v34.1.0) (2021-08-19)

### Bug Fixes

* **goal:** tooltip actual color ([#1302](#1302)) ([dbe9d36](dbe9d36))
* **heatmap:** improve legend item ([#1317](#1317)) ([49c35ce](49c35ce))
* **legend:** no truncation with single value ([#1316](#1316)) ([7ec8a9f](7ec8a9f))

### Features

* **goal:** optional target tick ([#1301](#1301)) ([88adf22](88adf22))
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 34.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@monfera monfera Awaiting requested review from monfera

Assignees
No one assigned
Labels
:data Data/series/scales related issue enhancement New feature or request :goal/gauge (old) Old Goal/Gauge chart related issues released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable target value
2 participants
@nickofthyme @markov00