Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(goal): tooltip actual color #1302

Merged
merged 5 commits into from Aug 17, 2021
Merged

fix(goal): tooltip actual color #1302

merged 5 commits into from Aug 17, 2021

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 15, 2021 •
edited

Summary

Fix goal tooltip color to show actual value of progress bar not white.

image

Checklist

  • The proper chart type label was added (e.g. :xy, :partition) if the PR involves a specific chart type
  • The proper feature label was added (e.g. :interactions, :axis) if the PR involves a specific chart feature

@nickofthyme nickofthyme added :styling Styling related issue :goal/gauge (old) Old Goal/Gauge chart related issues labels Aug 15, 2021
markov00
markov00 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If you want to add a screenshot with a visible tooltip it will be great

@nickofthyme nickofthyme enabled auto-merge (squash) August 17, 2021 15:34
@nickofthyme nickofthyme merged commit dbe9d36 into elastic:master Aug 17, 2021
@nickofthyme nickofthyme deleted the fix-tooltip-color branch August 17, 2021 16:08
nickofthyme pushed a commit that referenced this pull request Aug 19, 2021
@semantic-release-bot
chore(release): 34.1.0 [skip ci]
107617a 
# [34.1.0](v34.0.0...v34.1.0) (2021-08-19)

### Bug Fixes

* **goal:** tooltip actual color ([#1302](#1302)) ([dbe9d36](dbe9d36))
* **heatmap:** improve legend item ([#1317](#1317)) ([49c35ce](49c35ce))
* **legend:** no truncation with single value ([#1316](#1316)) ([7ec8a9f](7ec8a9f))

### Features

* **goal:** optional target tick ([#1301](#1301)) ([88adf22](88adf22))
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 34.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@monfera monfera Awaiting requested review from monfera

Assignees
No one assigned
Labels
:goal/gauge (old) Old Goal/Gauge chart related issues released Issue released publicly :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickofthyme @markov00