Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heatmap): reuse valueFormatter in legend #1318

Merged
merged 3 commits into from Aug 20, 2021
Merged

fix(heatmap): reuse valueFormatter in legend #1318

merged 3 commits into from Aug 20, 2021

Conversation

markov00
Copy link
Member

Summary

This fixes the missing usage of the valueFormatter in the heatmap legend

A story was fixed with a valid valueFormatter and the screenshot was updated accordingly.

all-test-ts-baseline-visual-tests-for-all-stories-heatmap-alpha-basic-visually-looks-correct-1-snap

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The proper documentation and/or storybook story has been added or updated

@markov00 markov00 added bug Something isn't working :legend Legend related issue :heatmap Heatmap/Swimlane chart related issue skip-newsletter labels Aug 20, 2021
@markov00 markov00 requested a review from monfera August 20, 2021 10:50
monfera
monfera approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@markov00 markov00 enabled auto-merge (squash) August 20, 2021 11:01
@markov00 markov00 merged commit e6a75d7 into elastic:master Aug 20, 2021
nickofthyme pushed a commit that referenced this pull request Aug 20, 2021
@semantic-release-bot
chore(release): 34.1.1 [skip ci]
a802471 
## [34.1.1](v34.1.0...v34.1.1) (2021-08-20)

### Bug Fixes

* **heatmap:** reuse the valueFormatter in legend ([#1318](#1318)) ([e6a75d7](e6a75d7))
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 34.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Aug 20, 2021
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 34.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monfera monfera monfera approved these changes

Assignees
No one assigned
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue :legend Legend related issue released on @34.1.x released Issue released publicly skip-newsletter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markov00 @nickofthyme @monfera