Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using pyproject.toml replace setup.py #2154

Open
ischaojie opened this issue Feb 7, 2023 · 4 comments
Open

Consider using pyproject.toml replace setup.py #2154

ischaojie opened this issue Feb 7, 2023 · 4 comments
Labels
good first issue Issues that are good for new contributors

Comments

@ischaojie
Copy link

Describe the feature:

pyproject.toml has become the de facto python project standard, perhaps we should replace the current setup.py with a tool such as hatch?

@sethmlarson
Copy link
Contributor

That would be a great improvement, let's use Hatch.

@NamanJainCG
Copy link

Hey, can someone help me solve this here, I am a beginner. Thanks in advance

@pquentin
Copy link
Member

Hello, I would suggest that you read https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html and https://packaging.python.org/en/latest/tutorials/packaging-projects/ first. You will also have to remove setup.py from noxfile.py and MANIFEST.in, and adjust the code in utils/build-dists.py to change the version in pyproject.toml.

@pquentin
Copy link
Member

pquentin commented Dec 8, 2023

That said, #2156 exists so I need to review it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are good for new contributors
Projects
None yet
Development

No branches or pull requests

4 participants