Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnError callback in esutil.BulkIndexerConfig is invoked duplicately #497

Open
iamorchid opened this issue May 29, 2022 · 0 comments
Open

Comments

@iamorchid
Copy link

In bulk_indexer.go, I see logic below:

func (w *worker) run() {
	go func() {     
                                ...  
                                if err := w.flush(ctx); err != nil {
					w.mu.Unlock()
					if w.bi.config.OnError != nil {
						w.bi.config.OnError(ctx, err)
					}
					continue
				}
                                 ...
        }()
}
func (w *worker) flush(ctx context.Context) error {
...
	if res.IsError() {
		atomic.AddUint64(&w.bi.stats.numFailed, uint64(len(w.items)))
		// TODO(karmi): Wrap error (include response struct)
		if w.bi.config.OnError != nil {
			w.bi.config.OnError(ctx, fmt.Errorf("flush: %s", err))
		}
		return fmt.Errorf("flush: %s", res.String())
	}
...
}

When flush fails, bi.config.OnError is called twice. One happens in flush function, and the other in the run function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant