Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Kibana installs Chromium headless browser when running the integration tests #102919

Closed
mshustov opened this issue Jun 22, 2021 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Team:Reporting Services Use Team:Global Experiance and Feature:Reporting instead. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@mshustov
Copy link
Contributor

mshustov commented Jun 22, 2021

Kibana version: master
PR #102782 failed CI on the Jest integration tests step with:

16:17:49  Summary of all failing tests
16:17:49   FAIL  src/core/server/saved_objects/migrationsv2/integration_tests/migration.test.ts (126.196 s)
16:17:49  
16:17:49  
16:17:49    ● Test suite failed to run
16:17:49  
16:17:49      TypeError: Cannot read property 'append' of undefined
16:17:49  
16:17:49        52 |
16:17:49        53 |     for (const appender of this.appenders) {
16:17:49      > 54 |       appender.append(record);
16:17:49           |                ^
16:17:49        55 |     }
16:17:49        56 |   }
16:17:49        57 |
16:17:49  
16:17:49        at BaseLogger.log (src/core/server/logging/logger.ts:54:16)
16:17:49        at BaseLogger.info (src/core/server/logging/logger.ts:33:10)
16:17:49        at LoggerAdapter.info (src/core/server/logging/logger_adapter.ts:36:17)
16:17:49        at LevelLogger.info (x-pack/plugins/reporting/server/lib/level_logger.ts:58:26)
16:17:49        at backgroundInstall (x-pack/plugins/reporting/server/browsers/install.ts:50:12)

which is caused by reporting plugin logging after Kibana stops.
There are 2 problems:

  • Reporting plugin doesn't interrupt the installation process when Kibana stopped
  • Reporting runs installation when unnecessary.

I fixed the problem by disabling the reporting plugin in this specific case, but it's rather a workaround.
@elastic/kibana-reporting-services is it possible to install a browser in dev mode by a request?
if no, @elastic/kibana-operations should we disable the reporting plugin by default in all the integration tests with oss: false? tbh, I'd like to avoid that because it means dev and test configuration diverge.

@mshustov mshustov added bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team Team:AppServices labels Jun 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 22, 2021
@tsullivan tsullivan added the (Deprecated) Team:Reporting Services Use Team:Global Experiance and Feature:Reporting instead. label Jun 22, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 22, 2021
@mshustov
Copy link
Contributor Author

today I had a false positive test failure due to this problem

● Test suite failed to run

    Failed to download https://storage.googleapis.com/headless_shell/chromium-d163fd7-darwin_x64.zip

https://github.com/elastic/kibana/pull/107130/checks?check_run_id=3199236871

cc @elastic/kibana-operations

@tsullivan tsullivan changed the title Kibana installs headless browser when running the integration tests [Reporting] Kibana installs Chromium headless browser when running the integration tests Aug 2, 2021
@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@tylersmalley tylersmalley removed loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 16, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort labels Mar 30, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Apr 11, 2022
@jbudz jbudz removed the Team:Operations Team label for Operations Team label May 10, 2022
@tsullivan
Copy link
Member

It seems this is no longer an issue. I am closing this to take it off our tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Team:Reporting Services Use Team:Global Experiance and Feature:Reporting instead. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Development

No branches or pull requests

5 participants