Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Reactify icons in Pipeline Viewer #18159

Closed
elasticmachine opened this issue Feb 22, 2018 · 3 comments
Closed

[Monitoring] Reactify icons in Pipeline Viewer #18159

elasticmachine opened this issue Feb 22, 2018 · 3 comments
Labels

Comments

@elasticmachine
Copy link
Contributor

Original comment by @justinkambic:

Presently the Logstash Pipeline Viewer is using icons that are defined in EUI. The PV does not use React and cannot easily reference the icons directly, so it instead references copies that live in Monitoring. We want to reference these icons directly from EUI if possible.

@elasticmachine
Copy link
Contributor Author

Original comment by @justinkambic:

In LINK REDACTED we changed the references to import the SVGs directly from EUI. This is better, because we are directly referencing the assets in their own package, rather than copying them into the monitoring plugin. When we Reactify the Pipeline Viewer, we will want to transition these references to use the associated icon component.

@justinkambic
Copy link
Contributor

@ycombinator do you think we still need to track this, given the current design goals of #18597?

@ycombinator
Copy link
Contributor

@justinkambic I don't think so, given how far and well #18597 has progressed. Feel free to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants