[FTR](combined) update common serverless api tests to use api keys #181741

wayneseymour · 2024-04-25T16:02:24Z

Summary

Contributes to: #180834

Update the below common tests, and figure out the minimum required role.

More Info

Add type for InternalRequestHeader
Add type for SupertestWithoutAuth
Add shortcut method: createApiKeyForDefaultRole to Serverless User Manager service
Change all calls of await supertest to await supertestWithoutAuth
Add Internal Request and Role Credential headers to every await supertestWithoutAuth http call
Use the lowest role credential possible for all calls, whether viewer, editor, developer, or admin

Covers these folders:

x-pack/test_serverless/api_integration/test_suites/common/console
x-pack/test_serverless/api_integration/test_suites/common/core
x-pack/test_serverless/api_integration/test_suites/common/data_view_field_editor
x-pack/test_serverless/api_integration/test_suites/common/elasticsearch_api
x-pack/test_serverless/api_integration/test_suites/common/grok_debugger
x-pack/test_serverless/api_integration/test_suites/common/kql_telemetry
x-pack/test_serverless/api_integration/test_suites/common/scripts_tests
x-pack/test_serverless/api_integration/test_suites/common/search_profiler
x-pack/test_serverless/api_integration/test_suites/common/search_xpack

wayneseymour · 2024-04-26T05:57:37Z

\ci

wayneseymour · 2024-04-26T16:24:53Z

\ci

wayneseymour · 2024-04-26T16:27:44Z

\ci

but now an assertion is failing.

x-pack/test_serverless/api_integration/test_suites/common/core/translations.ts

wayneseymour · 2024-05-06T15:09:07Z

\ci

wayneseymour · 2024-05-07T08:00:18Z

flaky x25 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5863

…vrless-api-tests/combined

wayneseymour · 2024-05-14T16:41:34Z

flaky x25: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5974

kibanamachine · 2024-05-14T17:44:22Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#5974

[✅] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 25/25 tests passed.

see run history

sabarasaba

Thanks for working on this @wayneseymour! Left few comments, let me know what you think 🚀

x-pack/test_serverless/api_integration/test_suites/common/console/autocomplete_entities.ts

x-pack/test_serverless/api_integration/test_suites/common/console/proxy_route.ts

dmlemeshko

Great work @wayneseymour I left some non-blocking questions

dmlemeshko · 2024-05-15T07:51:51Z

x-pack/test_serverless/api_integration/test_suites/common/console/es_config.ts

        .expect(200);
      expect(body.host).to.be.ok();
+      await svlUserManager.invalidateApiKeyForRole(roleAuthc);


suggestion : using before / after hooks to generate/invalidate API key; This way we will invalidate key even if it fails

x-pack/test_serverless/api_integration/test_suites/common/console/proxy_route.ts

x-pack/test_serverless/api_integration/test_suites/common/core/compression.ts

dmlemeshko · 2024-05-15T07:56:45Z

x-pack/test_serverless/api_integration/test_suites/common/elasticsearch_api/home.ts

+        .get('/')
+        .set(svlCommonApi.getCommonRequestHeader())
+        .set(roleAuthc.apiKeyHeader)
+        .redirects(2);


question: could you explain why do we need to allow redirects here?

Honestly, I do not know.
What I do know, is that the request fails without this, after I added my changes.

Ok, let's double check with code owners here

That'd be @pheyos :)

dmlemeshko · 2024-05-15T07:57:41Z

x-pack/test_serverless/shared/services/supertest.ts

 import { FtrProviderContext } from '../../functional/ftr_provider_context';
-
+export type SupertestWithoutAuthType = ProvidedType<typeof SupertestWithoutAuthProvider>;


…vrless-api-tests/combined

pmuellr

no ResponseOps code changes here, near as I can tell - I think there were previously some RO-hitting commits previously ...

Took a quick peek, as it appears the RO changes will be coming in a separate PR - a view of things to come! LGTM

kibana-ci · 2024-05-15T13:04:19Z

💚 Build Succeeded

Buildkite Build
Commit: 575f85d

Metrics [docs]

✅ unchanged

History

💚 Build #210076 succeeded b8c0592
💚 Build #209883 succeeded 76b4038
💔 Build #209855 failed bf8af15
💔 Build #209810 failed f67e959
💔 Build #209786 failed a3c7b06
💔 Build #209726 failed ac13a09

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

wayneseymour · 2024-05-15T13:11:59Z

no ResponseOps code changes here, near as I can tell - I think there were previously some RO-hitting commits previously ...

Took a quick peek, as it appears the RO changes will be coming in a separate PR - a view of things to come! LGTM

Thanks Pat!!

wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:QA Team label for QA Team labels Apr 25, 2024

wayneseymour self-assigned this Apr 25, 2024

wayneseymour mentioned this pull request Apr 26, 2024

FTR - update common serverless API tests to use API keys #180834

Open

wayneseymour force-pushed the update-common-svrless-api-tests/combined branch from fe430a7 to 7975cb4 Compare April 26, 2024 16:24

wayneseymour added 4 commits May 6, 2024 14:25

[FTR] update common serverless api tests to use api keys

c682091

data_view_fied_editor folder

d83c102

grok_debugger folder

72feb2b

kql_telemetry folder

af3a6c3

wayneseymour force-pushed the update-common-svrless-api-tests/combined branch from 7975cb4 to af3a6c3 Compare May 6, 2024 13:25

wayneseymour added 2 commits May 6, 2024 15:46

lower privs.

22dde6d

soooo, using viewer works,

e44e56d

but now an assertion is failing.

wayneseymour commented May 6, 2024

View reviewed changes

x-pack/test_serverless/api_integration/test_suites/common/core/translations.ts Outdated Show resolved Hide resolved

wayneseymour added 5 commits May 6, 2024 16:02

put this back

ecdbf00

use viewer

424004d

viewer works here too

6d28f9d

viewer

aacc98b

viewer

3b23cbf

wayneseymour changed the title ~~[FTR] update common serverless api tests to use api keys~~ [FTR](combined) update common serverless api tests to use api keys May 7, 2024

wayneseymour marked this pull request as ready for review May 7, 2024 08:43

wayneseymour requested review from a team as code owners May 7, 2024 08:43

wayneseymour added 4 commits May 13, 2024 21:46

only admin works now, for GET /api/console/es_config

b048a54

only admin now

35b098b

Merge branch 'main' of github.com:elastic/kibana into update-common-s…

91b7042

…vrless-api-tests/combined

add in changes from combined 2 branch

ac13a09

wayneseymour requested a review from a team as a code owner May 14, 2024 06:08

wayneseymour added 7 commits May 14, 2024 11:21

reverting alerting, to be in another pr

eecde2e

Merge branch 'main' of github.com:elastic/kibana into update-common-s…

db88350

…vrless-api-tests/combined

delete pr review comment: elastic#181741 (comment)

170b5fa

reverting translations, to be in another pr

a3c7b06

whoops, this also will be in the alerting branch.

f67e959

now editor works, and not viewer

bf8af15

use admin

76b4038

sabarasaba reviewed May 15, 2024

View reviewed changes

x-pack/test_serverless/api_integration/test_suites/common/console/autocomplete_entities.ts Show resolved Hide resolved

x-pack/test_serverless/api_integration/test_suites/common/console/proxy_route.ts Show resolved Hide resolved

sabarasaba approved these changes May 15, 2024

View reviewed changes

dmlemeshko reviewed May 15, 2024

View reviewed changes

yuliacech approved these changes May 15, 2024

View reviewed changes

wayneseymour added 4 commits May 15, 2024 10:01

Merge branch 'main' of github.com:elastic/kibana into update-common-s…

4c1fee3

…vrless-api-tests/combined

drop comment

56efd6f

add before / after per cr

b8c0592

revert

575f85d

pmuellr approved these changes May 15, 2024

View reviewed changes

wayneseymour requested a review from dmlemeshko May 15, 2024 13:12

dmlemeshko approved these changes May 15, 2024

View reviewed changes

wayneseymour merged commit f50b829 into elastic:main May 15, 2024
18 checks passed

kibanamachine added the v8.15.0 label May 15, 2024

wayneseymour mentioned this pull request May 17, 2024

Update supertest and superagent to latest version #183587

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FTR](combined) update common serverless api tests to use api keys #181741

[FTR](combined) update common serverless api tests to use api keys #181741

wayneseymour commented Apr 25, 2024 •

edited

wayneseymour commented Apr 26, 2024

wayneseymour commented Apr 26, 2024

wayneseymour commented Apr 26, 2024

wayneseymour commented May 6, 2024

wayneseymour commented May 7, 2024

wayneseymour commented May 14, 2024

kibanamachine commented May 14, 2024

sabarasaba left a comment

dmlemeshko left a comment

dmlemeshko May 15, 2024

wayneseymour May 15, 2024

dmlemeshko May 15, 2024

wayneseymour May 15, 2024

dmlemeshko May 15, 2024

wayneseymour May 15, 2024

dmlemeshko May 15, 2024

pmuellr left a comment

kibana-ci commented May 15, 2024

wayneseymour commented May 15, 2024

		import { FtrProviderContext } from '../../functional/ftr_provider_context';

		export type SupertestWithoutAuthType = ProvidedType<typeof SupertestWithoutAuthProvider>;

[FTR](combined) update common serverless api tests to use api keys #181741

[FTR](combined) update common serverless api tests to use api keys #181741

Conversation

wayneseymour commented Apr 25, 2024 • edited

Summary

More Info

Covers these folders:

wayneseymour commented Apr 26, 2024

wayneseymour commented Apr 26, 2024

wayneseymour commented Apr 26, 2024

wayneseymour commented May 6, 2024

wayneseymour commented May 7, 2024

wayneseymour commented May 14, 2024

kibanamachine commented May 14, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#5974

sabarasaba left a comment

Choose a reason for hiding this comment

dmlemeshko left a comment

Choose a reason for hiding this comment

dmlemeshko May 15, 2024

Choose a reason for hiding this comment

wayneseymour May 15, 2024

Choose a reason for hiding this comment

dmlemeshko May 15, 2024

Choose a reason for hiding this comment

wayneseymour May 15, 2024

Choose a reason for hiding this comment

dmlemeshko May 15, 2024

Choose a reason for hiding this comment

wayneseymour May 15, 2024

Choose a reason for hiding this comment

dmlemeshko May 15, 2024

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

kibana-ci commented May 15, 2024

💚 Build Succeeded

Metrics [docs]

History

wayneseymour commented May 15, 2024

wayneseymour commented Apr 25, 2024 •

edited