[Connectors][Jira] Validation error with empty additional fields #183163
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v8.14.0
v8.15.0
Comments
cnasikas
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
added
the
bug
adcoelho
added a commit
that referenced
this issue
May 14, 2024
Fixes #183163 ## Summary In this scenario, the API was being called with `otherFields: ''`. The backend expects `otherFields: schema.nullable(schema.recordOf(...))`. Initially, I thought about setting the value to `{}` when the user cleared the form but we had that behavior in the past in another field and I had to change it. 😅 Now I set the value to `null` and the API is called with valid values.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 14, 2024
Fixes elastic#183163 ## Summary In this scenario, the API was being called with `otherFields: ''`. The backend expects `otherFields: schema.nullable(schema.recordOf(...))`. Initially, I thought about setting the value to `{}` when the user cleared the form but we had that behavior in the past in another field and I had to change it. 😅 Now I set the value to `null` and the API is called with valid values. (cherry picked from commit 4ba10f0)
kibanamachine
added a commit
that referenced
this issue
May 14, 2024
…183359) # Backport This will backport the following commits from `main` to `8.14`: - [[Connectors] [Jira] Fixed bug in additional fields (#183285)](#183285) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Antonio","email":"antonio.coelho@elastic.co"},"sourceCommit":{"committedDate":"2024-05-14T07:41:08Z","message":"[Connectors] [Jira] Fixed bug in additional fields (#183285)\n\nFixes #183163\r\n\r\n## Summary\r\n\r\nIn this scenario, the API was being called with `otherFields: ''`.\r\n\r\nThe backend expects `otherFields:\r\nschema.nullable(schema.recordOf(...))`.\r\n\r\nInitially, I thought about setting the value to `{}` when the user\r\ncleared the form but we had that behavior in the past in another field\r\nand I had to change it. 😅\r\n\r\nNow I set the value to `null` and the API is called with valid values.","sha":"4ba10f02d37093966391958b1f77e708afa7372f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Actions/ConnectorTypes","v8.14.0","v8.15.0"],"title":"[Connectors] [Jira] Fixed bug in additional fields ","number":183285,"url":"#183285 [Jira] Fixed bug in additional fields (#183285)\n\nFixes #183163\r\n\r\n## Summary\r\n\r\nIn this scenario, the API was being called with `otherFields: ''`.\r\n\r\nThe backend expects `otherFields:\r\nschema.nullable(schema.recordOf(...))`.\r\n\r\nInitially, I thought about setting the value to `{}` when the user\r\ncleared the form but we had that behavior in the past in another field\r\nand I had to change it. 😅\r\n\r\nNow I set the value to `null` and the API is called with valid values.","sha":"4ba10f02d37093966391958b1f77e708afa7372f"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183285 [Jira] Fixed bug in additional fields (#183285)\n\nFixes #183163\r\n\r\n## Summary\r\n\r\nIn this scenario, the API was being called with `otherFields: ''`.\r\n\r\nThe backend expects `otherFields:\r\nschema.nullable(schema.recordOf(...))`.\r\n\r\nInitially, I thought about setting the value to `{}` when the user\r\ncleared the form but we had that behavior in the past in another field\r\nand I had to change it. 😅\r\n\r\nNow I set the value to `null` and the API is called with valid values.","sha":"4ba10f02d37093966391958b1f77e708afa7372f"}}]}] BACKPORT--> Co-authored-by: Antonio <antonio.coelho@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #179262 we added support for Jira's additional fields. If you go to Jira and type something in the "Additional fields" field, then remove it, and submit a validation error will be thrown.
Steps to reproduce
Screen.Recording.2024-05-10.at.6.01.49.PM.mov
The text was updated successfully, but these errors were encountered: