Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Lens): remove inline editor empty space #183258

Closed
wants to merge 4 commits into from

Conversation

markov00
Copy link
Member

Summary

This PR fixes a style issue in the inline editor.
The issue is visible in the Breakdown -> Advanced configuration where the Advanced accordion retained its content space even if it was closed.
I cleaned up the style where needed, removing what looked like unnecessary applied styles (not used anymore after the changes).

I've checked both ESQL and standard Lens visualization configurations.
I've also checked the @MichaelMarcialis PR comments from here #169911 to avoid breaking the style change previously requested.

Fix #180119

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Feature:Inline Editing labels May 13, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB -532.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 marked this pull request as ready for review May 14, 2024 09:44
@markov00 markov00 requested a review from a team as a code owner May 14, 2024 09:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@markov00 markov00 requested a review from stratoula May 14, 2024 09:44
@markov00 markov00 added v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels May 14, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for pinging me in this review Marco and for trying to solve this bug. I found 2 problems introduced with your PR:

  1. The drag and drop doesnt work ok now, it is hidden
    meow

  2. We want the visualization configuration title to be in a fixed position and the content to scroll (check the gif below) while in your implementation the entire container scrolls.

meow1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks stratoula, I pinged you exactly for these checks. I always forgot about the DnD, let me check also the title one.

@markov00 markov00 marked this pull request as draft May 20, 2024 16:09
@markov00
Copy link
Member Author

replaced by #184369

@markov00 markov00 closed this May 28, 2024
@markov00 markov00 deleted the reduce_inline_editor_space branch May 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inline Editing Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Blank space in the Lens inline editor in dashboards
5 participants