-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Lens): remove inline editor empty space #183258
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx for pinging me in this review Marco and for trying to solve this bug. I found 2 problems introduced with your PR:
-
We want the visualization configuration title to be in a fixed position and the content to scroll (check the gif below) while in your implementation the entire container scrolls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks stratoula, I pinged you exactly for these checks. I always forgot about the DnD, let me check also the title one.
replaced by #184369 |
Summary
This PR fixes a style issue in the inline editor.
The issue is visible in the
Breakdown -> Advanced
configuration where theAdvanced
accordion retained its content space even if it was closed.I cleaned up the style where needed, removing what looked like unnecessary applied styles (not used anymore after the changes).
I've checked both ESQL and standard Lens visualization configurations.
I've also checked the @MichaelMarcialis PR comments from here #169911 to avoid breaking the style change previously requested.
Fix #180119