-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sentinelone connector schema #183280
Merged
ashokaditya
merged 1 commit into
elastic:main
from
ashokaditya:fix/dw-sentinel-one-win-agent-status-bug
May 13, 2024
Merged
update sentinelone connector schema #183280
ashokaditya
merged 1 commit into
elastic:main
from
ashokaditya:fix/dw-sentinel-one-win-agent-status-bug
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokaditya
added
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
OLM Sprint
v8.14.0
labels
May 13, 2024
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
approved these changes
May 13, 2024
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @ashokaditya |
joeypoon
approved these changes
May 13, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 13, 2024
(cherry picked from commit 3c63379)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 13, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [update sentinelone connector schema (#183280)](#183280) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-13T17:12:33Z","message":"update sentinelone connector schema (#183280)","sha":"3c63379f350c8077a055fe412356f6890d5e2ecb","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Defend Workflows","OLM Sprint","v8.14.0","v8.15.0"],"title":"update sentinelone connector schema","number":183280,"url":"#183280 sentinelone connector schema (#183280)","sha":"3c63379f350c8077a055fe412356f6890d5e2ecb"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183280 sentinelone connector schema (#183280)","sha":"3c63379f350c8077a055fe412356f6890d5e2ecb"}}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
OLM Sprint
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.14.0
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the sentinel one connector schema so it is less strict on osUsername values that may not be present for some hosts with sentinel one integration. Without this, the agent status API that uses the connector logic fails at schema validation level and consequently breaks the alerts details agent status UX.
closes /issues/182330
Checklist