Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Simplify uuid test workaround #279

Closed
justinkambic opened this issue Jun 29, 2022 · 2 comments
Closed

[Enhancement] Simplify uuid test workaround #279

justinkambic opened this issue Jun 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@justinkambic
Copy link
Contributor

Feature summary

In #275 we implemented a workaround solution that will allow our tests to run in newer versions of Jest. It may be possible to simplify what we've done in a follow-up by having jest ignore uuid when it is transforming the TS, which would allow us to omit a custom resolver.

Why is this feature important?

It will simplify the unit testing infrastructure.

Linked resources

The linked PR includes links, also check out this PR for more info on the problem.

Additional information

No response

@justinkambic justinkambic added the enhancement New feature or request label Jun 29, 2022
@kyungeunni
Copy link
Member

kyungeunni commented Jun 30, 2022

If I understood it correctly, all the files under node_modules are ignored by transformers as default, meaning uuid module should be ignored. The way I see it, it's not the problem of transforming the TS but that uuid only provides ESM when we simulate the environment as a browser(jsdom). More details are described here:

@justinkambic
Copy link
Contributor Author

It sounds like for now we will keep the existing solution, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants