Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update fpm to fix rpm aarch64 build #49

Open
MrMYHuang opened this issue Apr 17, 2022 · 8 comments
Open

Please update fpm to fix rpm aarch64 build #49

MrMYHuang opened this issue Apr 17, 2022 · 8 comments

Comments

@MrMYHuang
Copy link

The aarch64 rpm built by electron-builder 23.0.4 can not installed on Fedora 35 Linux aarch64. For example,

sudo rpm -i https://github.com/MrMYHuang/cbetar2/releases/download/v19.0.0/cbetar2_19.0.0_linux_aarch64.rpm
        package cbetar2-19.0.0-1.arm64 is intended for a different architecture                                           

It seems to be a bug of fpm
jordansissel/fpm#1775
It has been fixed in fpm 1.13.0:
https://fpm.readthedocs.io/en/v1.13.1/changelog.html?highlight=arm64

Please update fpm to the latest version for fixing this issue. Thanks.

@MrMYHuang MrMYHuang changed the title Please update fpm to fix rpm build Please update fpm to fix rpm aarch64 build Apr 17, 2022
@MrMYHuang
Copy link
Author

I find a workaround:
electron-userland/electron-builder#5154 (comment)

sudo dnf install ruby ruby-devel
sudo gem install fpm
export USE_SYSTEM_FPM=true

electron-builder 23.0.4 works well with fpm-1.14.2 to build correct rpms on Fedora 35 Linux aarch64.

@mmaietta
Copy link

mmaietta commented Jun 5, 2022

Happy to review a PR! Setting up a dev env should be fairly simple: https://github.com/electron-userland/electron-builder/blob/master/CONTRIBUTING.md#to-setup-a-local-dev-environment

@mkurz
Copy link

mkurz commented Nov 8, 2022

Probably compiling for arm64/aarch64 will not be enough, also app-builder-bin needs to be aware of such an new version. I wrote a guide here: signalapp/Signal-Desktop#6063 (comment)
Feel free to pick up that work.

@pinkisemils
Copy link

The fix for this is to pass different arguments to fpm when building an RPM package for aarch64 - specifically, instead of passing --architecture arm64, one should be passing --architecture aarch64. Of course, maybe newer versions of FPM will do the switcheroo themselves.

@jgresham
Copy link

@develar if I can build a binary of a arm64/aarch64 fpm version, will you add it to the releases?

@jgresham
Copy link

jgresham commented Mar 19, 2024

I believe I have an arm64 executable for fpm https://github.com/jgresham/fpm-arm-binary along with a shell scrip to generate the binary. Compiles fpm v1.15.1

cc @mmaietta @mkurz @develar

@mkurz
Copy link

mkurz commented Mar 20, 2024

@jgresham I am not part of any project here and will not work on anything. I leave that to others. But thank you very much for you work and efforts! 👍

@jgresham
Copy link

@codebytere sorry for mention, but I can't get a reply from other devs. Could we get an arm64 fpm binary included in the releases on this repo?

I believe I have an arm64 executable for fpm https://github.com/jgresham/fpm-arm-binary along with a shell scrip to generate the binary. Compiles fpm v1.15.1

cc @mmaietta @mkurz @develar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants