From 8ffd9d42d89634be76fd4554f659f2b2512f2081 Mon Sep 17 00:00:00 2001 From: Christopher Lee Date: Thu, 23 Jun 2022 12:15:29 -0600 Subject: [PATCH] fix: prevent infinite looping of overwriteArtifact during Github publishing (#6958) --- .changeset/wild-crabs-prove.md | 5 +++++ packages/electron-publish/src/gitHubPublisher.ts | 6 ++---- 2 files changed, 7 insertions(+), 4 deletions(-) create mode 100644 .changeset/wild-crabs-prove.md diff --git a/.changeset/wild-crabs-prove.md b/.changeset/wild-crabs-prove.md new file mode 100644 index 0000000000..1f73a24539 --- /dev/null +++ b/.changeset/wild-crabs-prove.md @@ -0,0 +1,5 @@ +--- +"electron-publish": patch +--- + +fix: prevent infinite error looping of overwriteArtifact during github artifact uploads diff --git a/packages/electron-publish/src/gitHubPublisher.ts b/packages/electron-publish/src/gitHubPublisher.ts index 459c6351d4..d306815abd 100644 --- a/packages/electron-publish/src/gitHubPublisher.ts +++ b/packages/electron-publish/src/gitHubPublisher.ts @@ -198,12 +198,10 @@ export class GitHubPublisher extends HttpPublisher { requestProcessor ) .catch(e => { - if (this.doesErrorMeanAlreadyExists(e)) { - return this.overwriteArtifact(fileName, release).then(() => this.doUploadFile(attemptNumber, parsedUrl, fileName, dataLength, requestProcessor, release)) - } - if (attemptNumber > 3) { return Promise.reject(e) + } else if (this.doesErrorMeanAlreadyExists(e)) { + return this.overwriteArtifact(fileName, release).then(() => this.doUploadFile(attemptNumber + 1, parsedUrl, fileName, dataLength, requestProcessor, release)) } else { return new Promise((resolve, reject) => { const newAttemptNumber = attemptNumber + 1