From bfe29a5e991c2719032877bd7225b15b6b836221 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=5F?= <32569159+RoikkuTo@users.noreply.github.com> Date: Mon, 2 May 2022 00:35:25 +0200 Subject: [PATCH] fix: Unable to find latest version on GitHub (#6822) --- .changeset/ten-dragons-rest.md | 5 +++++ packages/electron-updater/src/providers/GitHubProvider.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/ten-dragons-rest.md diff --git a/.changeset/ten-dragons-rest.md b/.changeset/ten-dragons-rest.md new file mode 100644 index 0000000000..15e4d4c20d --- /dev/null +++ b/.changeset/ten-dragons-rest.md @@ -0,0 +1,5 @@ +--- +"electron-updater": patch +--- + +fix: Unable to find latest version on GitHub diff --git a/packages/electron-updater/src/providers/GitHubProvider.ts b/packages/electron-updater/src/providers/GitHubProvider.ts index 6e5767a744..c50427317d 100644 --- a/packages/electron-updater/src/providers/GitHubProvider.ts +++ b/packages/electron-updater/src/providers/GitHubProvider.ts @@ -31,7 +31,7 @@ export abstract class BaseGitHubProvider extends Provider< protected computeGithubBasePath(result: string): string { // https://github.com/electron-userland/electron-builder/issues/1903#issuecomment-320881211 const host = this.options.host - return host !== null && host !== "github.com" && host !== "api.github.com" ? `/api/v3${result}` : result + return host && !["github.com", "api.github.com"].includes(host) ? `/api/v3${result}` : result } }