Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it safe to delete/exclude “inspector” folder from Electron 5 package? #4005

Closed
aabuhijleh opened this issue Jul 2, 2019 · 5 comments
Labels

Comments

@aabuhijleh
Copy link

  • Version: 20.39.0
  • Target: 32-bit Windows

I’ve recently updated Electron from v4 to v5 and found a new ~9MB folder inspector containing 188 files in the installed Electron package at node_modules/electron/dist/resources/inspector or ${packagedApp}/resources/inspector after packaging with electron-builder. What is this for?

There seems to be no consequences for deleting this folder.

Is it safe to delete/exclude it from my packaged app?

Package used: electron@5.0.6 for 32-bit Windows

Thanks in advance!

@develar develar added the feature label Jul 2, 2019
@develar
Copy link
Member

develar commented Jul 2, 2019

I think, electron-builder will add special option to remove this folder (obviously, you will be not able to use devtools from chrome anymore).

@aabuhijleh
Copy link
Author

aabuhijleh commented Jul 2, 2019

@develar actually, I can still use devtools perfectly after removing it which is why I was so confused.

@develar
Copy link
Member

develar commented Jul 2, 2019

Then better to ask in electron github issue tracker, because builder just builds :)

@aabuhijleh
Copy link
Author

Alright I asked here.

@aabuhijleh
Copy link
Author

aabuhijleh commented Jul 16, 2019

@develar develar closed this as completed Jul 16, 2019
@develar develar added question and removed feature labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants