New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error signing after upgrade of NodeJS #4932
Comments
Hi, Again sorry for the long message and forgive me if not clear - I've been struggling with it for few days now. After correctly running debug mode (🤦), Why do I suspect this? I was looking how to deep sign or avoid sign an internal application,
It lets you ignore signing for anything in the PlugIns path, However the build still fails to verify the "packaged" app - with the same error as before
I've made sure that the internal app is signed (same developer id) on the source folder and it looks ok (checked both with codesign and spctl):
So I suspect the copy of the source (signed) app to the target ".app" does not retain the files structure/permissions/etc... What I need help with
Other thoughts: I've looked ad the sign.js file And found that it does verify with --deep argument is used for verifying the signatures, This sounds like a good behaviour by default but I don't see way to override it, |
Is this possibly related? electron/osx-sign#228 |
Hi @pfrazee I've tried using the electron9.0.0-beta24 and I get the same error as in the link you provided
I'll check it again later |
Tried again with electron@9.0.0 (not beta) I still getting the error as in electron/electron#23534 |
This fix was directly lifted from electron/osx-sign#228 authored by @MarshallOfSound
I've submitted a fix PR https://github.com/electron-userland/electron-builder/pull/4993/files I've tested this multiple times (I had to apply the patch manually in my node_modules to create a recent release of my Electron project). |
Thanks @pfrazee I'll try to do the same (edit in the node_modules) |
@pfrazee I did as you and edited the node_modules and it's passed the electron 9 error as you intend to fix. my original issue still persist. |
Sign macOS objects depth-first (close electron-userland#4932)
Hi @develar my issue still persist When I check the signature of my internal app in it's directory I get user@machine bin % codesign --verify --verbose internal.app
internal.app: valid on disk
internal.app: satisfies its Designated Requirement when I check it in the output folder after running electron-builder I get this error user@machine bin % codesign --verify --verbose internal.app
internal.app: code object is not signed at all
In subcomponent: /Users/user/...PathToOutput.../Internal.App/Contents/Info.xml I haven't ruled out this maybe something with the internal app, If I install NodeJS 8.11 i don't get this error (but I also need to use electron-builder@22.4.1) Is it possible to delegate the sign to the user? the same way it's on windows? "win": {
"sign": "sign.js",
}, This way I can make a work-around |
Hi just leaving this here, in case someone runs into the same issue. The problem was not in the electron-builder but was related to how the internal app is signed before including it in the main electron app. for detailed info see here https://stackoverflow.com/questions/54149144/cannot-codesign-an-app-with-python-and-node The main gist of it is, Thanks all! |
Target: Zip,DMG
OS Version: macOS v10.13.6
Heads up it might be long,
Summary:
After upgrade node version from 8.11.1 to 12.16.3, I started getting sign errors, which were ignored with older version of NodeJS (using the same electron-builder version!).
Longer story:
I wanted to update electron-builder from version 22.4.1 to 22.6.0,
I saw that a new syntax was used in the newer version that didn't fly welll with the older NodeJS version
a catch without () brackets was throwing syntax error as part of the install-app-deps step
So I've upgraded the station to node V12.16.3 and started getting sign errors.
I include another app ("Another.app") in the electron app ("My.app") both are developed in-house.
Everything was signed and packaged smoothly with Node 8.11.1.
The error I'm getting with the NodeJS 12.16.3 is "code object is not signed at all" error code when signing the electron app
What I tried:
Running with DEBUG=electron-builder doesn't provide more info to the error
I've looked at
Codesign Error MacOS 10.13 #2125
My apps don't have special characters, just letters and space
deep signing of electron app not working with electron builder. #1546
I could not find how add the --deep programatically
I made sure that the internal app is not changed(process still working on another machine that has Node 8.11.1 & builder 22.4.1)
with the Node 12.16.3 it fails also with electron-builder version 22.4.1
I suspect that codesign returns "warning" in the stderr which was ignored on earlier combination of Node & electron-builder, but are not ignored anymore.
To summarise my very long issue - what I am asking is
The text was updated successfully, but these errors were encountered: