Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 9.0 electron-osx-sign update #4989

Closed
bigshahan opened this issue May 19, 2020 · 5 comments
Closed

Electron 9.0 electron-osx-sign update #4989

bigshahan opened this issue May 19, 2020 · 5 comments
Labels

Comments

@bigshahan
Copy link

bigshahan commented May 19, 2020

  • Version: v22.6.1
  • Electron Version: v9.0.0
  • Electron Type (current, beta, nightly): current
  • Target: mac

The electron-osx-sign library inside electron-builder needs to be updated with the following change to allow the signing to occur correctly.

See:
electron/electron#23565

electron/osx-sign#228

@athenawisdoms
Copy link

athenawisdoms commented May 21, 2020

Also experiencing this problem on Mac OS X Catalina 10.15.3.

Please update the version of electron-osx-sign :)

@lutzroeder
Copy link
Contributor

Duplicate of #4969

@alchaplinsky
Copy link
Contributor

alchaplinsky commented May 23, 2020

+1 Having issues with signing app. Electron v9.0.0

@dariocravero
Copy link

until #4993 or a similar solution gets merged, monkey patching node_modules/app-builder-lib/electron-osx-sign/sign.js with the code on that PR works

@stale
Copy link

stale bot commented Jul 25, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Jul 25, 2020
@stale stale bot closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants