Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CancellationToken class is no longer exported from electron-updater package #5675

Closed
NilSet opened this issue Mar 4, 2021 · 3 comments · Fixed by #5869
Closed

CancellationToken class is no longer exported from electron-updater package #5675

NilSet opened this issue Mar 4, 2021 · 3 comments · Fixed by #5869

Comments

@NilSet
Copy link

NilSet commented Mar 4, 2021

  • electron-updater Version: 4.3.8

  • Electron Version: 11.1.1

  • Electron Type (current, beta, nightly): current

In previous versions of electron-updater, the CancellationToken class accepted in downloadUpdate was exported from the electron-updater package. After the change in d05a62b#diff-696065e91abd75ef7fc5992339caf92ac5a4bb3625474c8cb04f94fd1953f39f we need to import it directly from the transitive dependency builder-util-runtime.

Given that this class is part of the external api of electron-updater the class should still be exported from there.

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 5, 2021

I agree with you, but I'm hoping I can get more context on the original changes first

@mastergberry, why was export { CancellationToken } from "builder-util-runtime" removed in your PR: https://github.com/electron-userland/electron-builder/pull/5515/files

@mastergberry
Copy link
Contributor

Think this was a mistake to be honest...feel free to submit a quick PR to revert it.

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 9, 2021

No worries! Just wanted to double-check first 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants