Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder does not seem to fully support custom publish providers #5854

Closed
strisys opened this issue May 3, 2021 · 3 comments
Closed

Comments

@strisys
Copy link

strisys commented May 3, 2021

  • Versions/targets:
    • electron: 12.0.5, current
    • electron-updater 4.3.8
    • Target: windows

The error is not with electron but with the publish capability of electron-builder using a custom publish provider

   package.json
  -----------------
   ....
    "publish": {
      "provider": "custom"
    }

I have a custom provider implemented to publish to Microsoft Azure (nsis-custom-publish.zip) and only some of the files make it there but not all. What is also interesting is that when I DO NOT publish (i.e. --publish never) I observe the following error.

> electron-builder build --win --x64 --publish never

  • electron-builder  version=22.10.5 os=10.0.19042
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist\electron\installer\builder-effective-config.yaml
  • packaging       platform=win32 arch=x64 electron=12.0.5 appOutDir=dist\electron\installer\win-unpacked
  • Unpacking electron zip  zipPath=undefined
electron-publisher-custom - module loaded
  • building        target=nsis file=dist\electron\installer\Contoso Analytics Setup 1.0.41.exe archs=x64 oneClick=true perMachine=false
  • building        target=nsis-web file=dist\electron\installer\nsis-web\Contoso Analytics Web Setup 1.0.41.exe archs=x64 oneClick=true perMachine=false
  • building embedded block map  file=dist\electron\installer\nsis-web\create-deploy-autoupdate-1.0.41-x64.nsis.7z
  • building block map  blockMapFile=dist\electron\installer\Contoso Analytics Setup 1.0.41.exe.blockmap
  ⨯ Not supported provider: custom  stackTrace=
                                      Error: Not supported provider: custom
                                          at getS3LikeProviderBaseUrl (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\builder-util-runtime\src\publishOptions.ts:231:9)
                                          at computeDownloadUrl (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\app-builder-lib\src\publish\PublishManager.ts:346:15)
                                          at WebInstallerTarget.configureDefines (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\app-builder-lib\src\targets\nsis\WebInstallerTarget.ts:31:23)
                                          at WebInstallerTarget.buildInstaller (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\app-builder-lib\src\targets\nsis\NsisTarget.ts:240:7)
                                          at WebInstallerTarget.finishBuild (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\app-builder-lib\src\targets\nsis\NsisTarget.ts:110:7)
                                          at async Promise.all (index 3)
                                          at AsyncTaskManager.awaitTasks (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\builder-util\src\asyncTaskManager.ts:65:25)
                                          at Packager.doBuild (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\app-builder-lib\src\packager.ts:446:5)
                                          at executeFinally (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\builder-util\src\promise.ts:12:14)
                                          at Packager._build (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\app-builder-lib\src\packager.ts:369:31)
                                          at Packager.build (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\app-builder-lib\src\packager.ts:333:12)
                                          at executeFinally (G:\web\client\_exercises\electron-create-deploy-autoupdate-trudel\source\2-nsis-custom-publish\node_modules\builder-util\src\promise.ts:12:14)
ERROR: "eb-build" exited with 1.

I am doubtful this error is indicative of the real problem. Any help would be appreciated otherwise I can write my own publisher script outside of using electron-builder. Thank you

@stale
Copy link

stale bot commented Jul 8, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Jul 8, 2021
@mmaietta
Copy link
Collaborator

mmaietta commented Jul 8, 2021

A custom provider should be supported in the latest 22.11.8
#5984

@stale
Copy link

stale bot commented Sep 7, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Sep 7, 2021
@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants