Issue 5857 ${arch} causes a build fail #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems here as reported in Issue #5857
If you are only using one architecture and you have a ${arch} in the pattern you get the file twice, once from this.archs and once from inside the loop added on line 124. This duplication meant that the builder was trying to output to the same file with two builds and failed. I have added a check to only add individual architectures, if the size of this.archs is greater than 1.
I've also changed each arch to build sequentially. The reason for this is the build was failing because it couldn't access the 7zip files or uninstaller for the build process because it was locked, causing the build to fail.
This seems to fix things, though someone else might have a better way of doing it?