Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Support the Electron Fuse: "EnableEmbeddedAsarIntegrityValidation" #6930

Open
Nantris opened this issue Jun 8, 2022 · 7 comments

Comments

@Nantris
Copy link

Nantris commented Jun 8, 2022

See here for more info: electron/fuses#7 (comment)

@kevinlinv
Copy link
Contributor

+1, I think support for electron/fuses would be a great addition.

FYI, there was also a closed #6365 issue that request support.

@mmaietta
Copy link
Collaborator

mmaietta commented Jul 4, 2022

Closing this one and reopening the other ticket.

@mmaietta mmaietta closed this as completed Jul 4, 2022
@Nantris
Copy link
Author

Nantris commented Jul 5, 2022

@mmaietta all the other fuses can be used without necessitating changes to Electron Builder itself. This one cannot. I think this should remain open because of that distinction.

@Nantris
Copy link
Author

Nantris commented Jul 27, 2022

From electron/fuses#7 (comment):

We're using Electron-Builder to package our app.

That would be your problem 😅. If you look at the official @electron/asar package, there is a module dedicated to generating these hashes. electron-builder, however, rolled their own ASAR creation code which doesn't have support for creating these hashes.

@mmaietta mmaietta reopened this Jul 27, 2022
@rafaberaldo
Copy link
Contributor

Would love to see this on electron-builder, Electron@30 added support for Windows machines as well.

@osztenkurden
Copy link

Is this currently on the roadmap? Given added support for Windows its kinda a big feature.

@mmaietta
Copy link
Collaborator

The only way to support this is by migrating to @electron/asar package. Unfortunately, I've tried to do so several times over the past few years and still haven't gotten to a solution that works. There's a lot of additional functionality that electron-builder relies on, such as transforming file data instead of copying a file directly. I can try and investigate this again, but can't promise anything. I'm the only maintainer on this project that remains (community contributions welcome!), so there's not really an "official" roadmap tbh, just trying to keep my head above the water with the combo of work+life outside of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants