Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squirrel.Windows does not support ARM64 #7492

Closed
t3chguy opened this issue Mar 22, 2023 · 7 comments
Closed

Squirrel.Windows does not support ARM64 #7492

t3chguy opened this issue Mar 22, 2023 · 7 comments
Labels

Comments

@t3chguy
Copy link
Contributor

t3chguy commented Mar 22, 2023

  • Electron-Builder Version: 24.0.0
  • Node Version: 18
  • Electron Version: 23
  • Electron Type (current, beta, nightly): current
  • Target: Windows arm64

The app builds fine and works as expected in unpacked mode, but in Squirrel.Windows mode it will not run due to Squirrel/Squirrel.Windows#1616 - updating to Squirrel.Windows v2 should fix it due to Squirrel/Squirrel.Windows#1617 having landed.

@mmaietta
Copy link
Collaborator

So it looks like that binary is coming from electron-builder-binaries: https://github.com/electron-userland/electron-builder-binaries/tree/master/Squirrel.Windows

vendorPath: await getBinFromUrl("Squirrel.Windows", "1.9.0", "zJHk4CMATM7jHJ2ojRH1n3LkOnaIezDk5FAzJmlSEQSiEdRuB4GGLCegLDtsRCakfHIVfKh3ysJHLjynPkXwhQ=="),

My best recommendation is to open an issue there to have those binaries updated to v2. Currently, it appears to be v1.9. I don't know how to update the binaries in electron-builder-binaries (nor have write access to do so)

@t3chguy
Copy link
Contributor Author

t3chguy commented Mar 22, 2023

@mmaietta done

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 22, 2023
@baxyz
Copy link

baxyz commented Apr 24, 2023

Any update?

@mmaietta
Copy link
Collaborator

Any update will be on the upstream issue in the upstream repo
electron-userland/electron-builder-binaries#52

No need to bump this issue.

@github-actions github-actions bot removed the Stale label Apr 25, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 26, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants