You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to this custom-nsis-script , in question How do change the default installation directory to custom? there is sample of macro to use to set custom default install location.
I use that successfully with previous version of electron-builder (v20x), but in current version (24x) this functionality is broken.
Same bug was reported in #6369 but was closed due to inactivity ? That problem still persist in latest version.
My observations:
my project uses (till now) version 20.38.5 of electron-builer and when i set custom install location via recommended NSI script:
and productName is MyCompany Super Product and run MSI installer (without changing install location in installer UI) my app is properly installed in c:\MyApp where i can find exe file eg. c:\MyApp\myapp.exe - this is expected and valid
But updating to latest version 24.9.1 with same nsi preInit script, and values, my app is installed into folder c:\MyApp\MyCompany Super Product and exe is found in c:\MyApp\MyCompany Super Product\myapp.exe - this is unexpected and wrong.
I found (thanks to @xyyHIT) what causing this is in file app-builder-lib/templates/nsis/assistedInstaller.nsh and function instFilesPre, where old was:
Function instFilesPre
${If}${FileExists}"$INSTDIR\*"${StrContains}$0"${APP_FILENAME}"$INSTDIR${If}$0=="" StrCpy$INSTDIR"$INSTDIR\${APP_FILENAME}"${endIf}${endIf} FunctionEnd
but new one has:
Function instFilesPre
${StrContains}$0"${APP_FILENAME}"$INSTDIR${If}$0=="" StrCpy$INSTDIR"$INSTDIR\${APP_FILENAME}"${endIf} FunctionEnd
missing ${If} on first line of function. Maybe this change fixes some other issue or was changed by mistake. Can you elaborate this? For now im stuck on older version.
The text was updated successfully, but these errors were encountered:
According to this custom-nsis-script , in question
How do change the default installation directory to custom?
there is sample of macro to use to set custom default install location.I use that successfully with previous version of
electron-builder
(v20x), but in current version (24x) this functionality is broken.Same bug was reported in #6369 but was closed due to inactivity ? That problem still persist in latest version.
My observations:
my project uses (till now) version
20.38.5
ofelectron-builer
and when i set custom install location via recommended NSI script:and
productName
isMyCompany Super Product
and run MSI installer (without changing install location in installer UI) my app is properly installed inc:\MyApp
where i can find exe file eg.c:\MyApp\myapp.exe
- this is expected and validBut updating to latest version
24.9.1
with samensi
preInit script, and values, my app is installed into folderc:\MyApp\MyCompany Super Product
and exe is found inc:\MyApp\MyCompany Super Product\myapp.exe
- this is unexpected and wrong.I found (thanks to @xyyHIT) what causing this is in file
app-builder-lib/templates/nsis/assistedInstaller.nsh
and functioninstFilesPre
, where old was:but new one has:
missing
${If}
on first line of function. Maybe this change fixes some other issue or was changed by mistake. Can you elaborate this? For now im stuck on older version.The text was updated successfully, but these errors were encountered: