Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-updater and github provider doesn't work when files have spaces in them #8172

Open
theogravity opened this issue Apr 11, 2024 · 4 comments

Comments

@theogravity
Copy link

theogravity commented Apr 11, 2024

  • Electron-Builder Version: 24.13.3
  • Node Version: 20
  • Electron Version: 29
  • Electron Type (current, beta, nightly): current

5.3.0

  • Target: mac

If my built app / package uses a space in the name, the resulting latest-mac.yml file will list the url with the appropriate spaces, eg My Application-v1-universal-mac.zip.

However, when using the github provider, the download will fail because when you publish files to github releases, they convert spaces to a period / dot, so the resulting download being offered from GH releases is actually My.Application-v1-universal-mac.zip.

The logic for reading the latest.yml / latest-<platform>.yml manifest needs to account for this behavior when using the github provider.

@mlshv
Copy link

mlshv commented Apr 12, 2024

I've noticed it too. Had to remove spaces from my app's name because of it

@parz3val
Copy link

This is because github replaces your space with ., Use '-' when you build your app and it'll work.

@theogravity
Copy link
Author

This is because github replaces your space with ., Use '-' when you build your app and it'll work.

Doesn't help when the app name itself has spaces in it.

And yes, as noted in the issue you can work around it but it's not ideal.

@parz3val
Copy link

And yes, as noted in the issue you can work around it but it's not ideal.

I literally have the same issue. But I am only replacing the space in the name of installer not the app itself. And yes, I agree its not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants