From 232f0720f1bf7f852440d57cc18ef2ab2dffa017 Mon Sep 17 00:00:00 2001 From: Blake Byrnes Date: Fri, 22 Apr 2022 12:15:11 -0400 Subject: [PATCH 1/2] fix: github provider prerelease typescript cast --- packages/electron-updater/src/providers/GitHubProvider.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/electron-updater/src/providers/GitHubProvider.ts b/packages/electron-updater/src/providers/GitHubProvider.ts index 4324dcdf74..12e354c8aa 100644 --- a/packages/electron-updater/src/providers/GitHubProvider.ts +++ b/packages/electron-updater/src/providers/GitHubProvider.ts @@ -57,7 +57,7 @@ export class GitHubProvider extends BaseGitHubProvider { let tag: string | null = null try { if (this.updater.allowPrerelease) { - const currentChannel = this.updater?.channel || String(semver.prerelease(this.updater.currentVersion)?.[0]) || null + const currentChannel = this.updater?.channel || semver.prerelease(this.updater.currentVersion)?.[0] as string || null for (const element of feed.getElements("entry")) { // noinspection TypeScriptValidateJSTypes const hrefElement = hrefRegExp.exec(element.element("link").attribute("href"))! @@ -68,7 +68,7 @@ export class GitHubProvider extends BaseGitHubProvider { // This Release's Tag const hrefTag = hrefElement[1] //Get Channel from this release's tag - const hrefChannel = semver.prerelease(hrefTag)?.[0] || null + const hrefChannel = semver.prerelease(hrefTag)?.[0] as string || null const shouldFetchVersion = !currentChannel || ["alpha", "beta"].includes(currentChannel) const isCustomChannel = !["alpha", "beta"].includes(String(hrefChannel)) From 62a96448930bcb5f3a24dc8df9c71934bc1f66ac Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Sat, 23 Apr 2022 17:09:15 -0700 Subject: [PATCH 2/2] Create giant-dancers-march.md --- .changeset/giant-dancers-march.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/giant-dancers-march.md diff --git a/.changeset/giant-dancers-march.md b/.changeset/giant-dancers-march.md new file mode 100644 index 0000000000..197d1b1bcb --- /dev/null +++ b/.changeset/giant-dancers-march.md @@ -0,0 +1,5 @@ +--- +"electron-updater": patch +--- + +fix: github provider prerelease check incorrectly casts undefined to String. Resolves #6809