Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash with lodash-es? #194

Open
Nantris opened this issue Dec 1, 2022 · 4 comments
Open

Replace lodash with lodash-es? #194

Nantris opened this issue Dec 1, 2022 · 4 comments

Comments

@Nantris
Copy link
Contributor

Nantris commented Dec 1, 2022

This appears to be the only reason that lodash is included in our bundles. It would be great to migrate to the more tree-shakeable lodash-es.
@Nantris
Copy link
Contributor Author

Nantris commented Dec 1, 2022

@jviotti pinging you on this because you seem to be the most active contributor.

A big thanks to you for all the great work!

@jviotti
Copy link
Member

jviotti commented Dec 1, 2022

Hey @slapbox ,

Sounds good to me! I haven't heard about lodash-es, but if you can send a quick PR, I'll issue a release ASAP. Thanks a lot!

@Nantris
Copy link
Contributor Author

Nantris commented Dec 7, 2022

@jviotti thanks for your reply!

I found out we actually have two other dependencies that depend on lodash, so this has moved down in priority for us quite a bit, but I'm still open to submitting a PR when I can.

PS thanks for your email - I saw it, but it's going to take me some time to get back to you since it's crunch time here right now.

@jviotti
Copy link
Member

jviotti commented Dec 8, 2022

No hurries. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jviotti @Nantris