New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target arch API #727

Merged

malept merged 2 commits into master from target-arch-api

Sep 14, 2017

Member

malept commented Sep 13, 2017

I have read the contribution documentation for this project.
I agree to follow the code of conduct that this project follows, as appropriate.
The changes are appropriately documented (if applicable).
The changes have sufficient test coverage (if applicable).
The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds two API functions in target.js:

hostArch, which is the same function as electronHostArch in Electron Forge and is used internally as well
allOfficialArchsForPlatformAndVersion, made specifically for Forge (Use the Electron Packager official platform/arch list forge#320). It might be nice to eventually use it internally, but it would take a nontrivial refactor.

malept added 2 commits

September 12, 2017 18:22


          Add hostArch from Electron Forge


          Add allOfficialArchsForPlatformAndVersion()

43397e8

malept mentioned this pull request

Use the Electron Packager official platform/arch list electron/forge#320

Merged

7 tasks

malept merged commit ab0419f into master

malept deleted the target-arch-api branch

September 14, 2017 02:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment