Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish promisification refactor #753

Merged
merged 10 commits into from Nov 14, 2017
Merged

Conversation

malept
Copy link
Member

@malept malept commented Nov 12, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

With this PR, all of the codebase has been converted to use promises instead of callbacks. Additionally, the code has been largely restructured to use ES6 classes, so it's hopefully easier to follow. This is obviously a really large PR that isn't easy to review (and it was difficult to find any place to split out work), so it may be easier to look at the new code and 馃 馃 the tests all pass (they all passed locally and Travis passed when I ran it on the branch).

run-series has been dropped, but callback support is retained with nodeify. I don't see dropping support for callbacks in packager(...) any time soon.

The breaking change is that when you specify multiple targets, they are run "in parallel", due to the usage of Promise.all. This fixes #123 to some extent.

@malept malept force-pushed the finish-promisifying branch 2 times, most recently from d7e44b4 to 2b665d6 Compare November 13, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel builds?
1 participant